ci: Fix path filter in PR Reporter action#4644
Merged
rschristian merged 1 commit intomainfrom Jan 25, 2025
Merged
Conversation
JoviDeCroock
approved these changes
Jan 25, 2025
Member
Author
|
Posting this here for myself in the future: whilst it seems like an obvious improvement to copy this to the CI workflow, ensuring it filters based on the latest commit only (thereby skipping running the benches for commits that haven't changed the source JS themselves), unfortunately That might (& hopefully will) change, but for now, this is the best we can do short of splitting off the benches too, which I don't find particularly compelling. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4643
The action is running again but it falls over as it cannot use the branch name from the fork as a reference to compare against -- that'll only work for local branches. To fix this, we simply switch over to the SHA, should do the trick for both forks & local branches all the same.
Tests here, if anyone cares to take a look. Top 3 are a local branch (real workflow + 2
workflow_run-triggered events), 3 after that are from a fork.